aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/platform
diff options
context:
space:
mode:
authorLu Wei <[email protected]>2020-07-10 17:30:17 +0800
committerAndy Shevchenko <[email protected]>2020-07-14 15:43:08 +0300
commit71fbe886ce6dd0be17f20aded9c63fe58edd2806 (patch)
tree960cecac92483c407e6ed4a350edc43d1c242010 /drivers/platform
parentplatform/x86: intel_pmc_core: fix bound check in pmc_core_mphy_pg_show() (diff)
downloadwireguard-linux-71fbe886ce6dd0be17f20aded9c63fe58edd2806.tar.xz
wireguard-linux-71fbe886ce6dd0be17f20aded9c63fe58edd2806.zip
platform/x86: intel-hid: Fix return value check in check_acpi_dev()
In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL() to check return value. Fixes: ecc83e52b28c ("intel-hid: new hid event driver for hotkeys") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Lu Wei <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/intel-hid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 9ee79b74311c..86261970bd8f 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -571,7 +571,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
return AE_OK;
if (acpi_match_device_ids(dev, ids) == 0)
- if (acpi_create_platform_device(dev, NULL))
+ if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
dev_info(&dev->dev,
"intel-hid: created platform device\n");
OSZAR »